Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All 1.3 tn dev #194

Merged
merged 8 commits into from
Oct 30, 2024
Merged

All 1.3 tn dev #194

merged 8 commits into from
Oct 30, 2024

Conversation

gouravmore
Copy link
Member

@gouravmore gouravmore commented Oct 30, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Introduced a zoom feature for images in the Mechanics5 component, allowing users to view images in a larger modal.
    • Added a new GitHub Actions workflow to automate the deployment process for the application.

  • Bug Fixes

    • Enhanced error handling and logic for mechanics and practice session flow, improving overall stability and user experience.

  • Chores

    • Streamlined deployment process to AWS S3, ensuring efficient updates and management of application builds.

gouravmore and others added 8 commits October 25, 2024 10:32
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Oct 30, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

A new GitHub Actions workflow named all-dev-tn-new.yml has been added to automate the deployment process for the all-1.3-tn-dev branch. This workflow triggers on pushes to the branch and includes a series of steps to check out code, set up Node.js, configure AWS credentials, clean up the environment, install dependencies, run Husky, build the application, deploy to an S3 bucket, debug environment variables, and invalidate the CloudFront cache. Additionally, enhancements have been made to the Mechanics5, VoiceAnalyser, and Practice components to improve functionality and user interaction.

Changes

File Change Summary
.github/workflows/all-dev-tn-new.yml New workflow created for deployment on all-1.3-tn-dev branch with multiple automation steps.
src/components/Practice/Mechanics5.jsx Added zoom functionality with a modal for image viewing; introduced new state variable zoomOpen.
src/utils/VoiceAnalyser.js Modified fetchASROutput to include conditional logic for updating stored data based on learner progress. Removed direct call to updateStoredData from button click.
src/views/Practice/Practice.jsx Enhanced error handling and logic for mechanics rendering; improved string length checks and state management.

Possibly related PRs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gouravmore gouravmore merged commit b699634 into all-1.2-tn-dev Oct 30, 2024
1 check passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

bharathrams pushed a commit to Bhashabyasa/nd-all-learner-ai-app that referenced this pull request Dec 2, 2024
@gouravmore
Merge pull request Sunbird-ALL#194 from Sunbird-ALL/all-1.3-tn-dev
7246a92 
All 1.3 tn dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gouravmore @ajinkyapandetekdi